Manage yumrepos via data #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinzent
reviewed
Feb 6, 2017
| @@ -27,6 +27,7 @@ | |||
| default_facts.merge!(YAML.load(File.read(File.expand_path('../default_facts.yml', __FILE__)))) if File.exist?(File.expand_path('../default_facts.yml', __FILE__)) | |||
| default_facts.merge!(YAML.load(File.read(File.expand_path('../default_module_facts.yml', __FILE__)))) if File.exist?(File.expand_path('../default_module_facts.yml', __FILE__)) | |||
| c.default_facts = default_facts | |||
| c.hiera_config = File.expand_path(File.join(__FILE__, '../fixtures/hiera.yaml')) | |||
There was a problem hiding this comment.
i think this will be overriden by modulesync.
There was a problem hiding this comment.
As far as spec_helper.rb goes, I've filed a modulesync_config PR (voxpupuli/modulesync_config#317).
lamawithonel
force-pushed
the
repos
branch
3 times, most recently
from
bd8d391 to
4b0e6bd
Compare
|
@vinzent This latest version adds a parameter to toggle management of the OS repos, defaulting to |
hunner
reviewed
Feb 9, 2017
manifests/init.pp
Outdated
| # @param manage_os_default_repos [Boolean] | ||
| # Whether or not to add an operating system's default repos to the `managed_repos` array. | ||
| # | ||
| # @note Currently only valid on CentOS. |
There was a problem hiding this comment.
This parameter is valid on other OSs, but os_default_repos will provide no defaults for any OS other than CentOS 6/7. Perhaps say something like "currently only provides defaults for CentOS" on the os_default_repos parameter instead?
This commit adds parameters to manage Yumrepo resources via data. The
primary parameter, `repos`, is a hash of Yumrepo resources for digestion
by an each loop similar to an old `create_resources()` call. It does
nothing on its own, acting only as a source of data. The othe
parameters control the behavior of the resource instantiation loop.
The parameters `managed_repos`, `os_default_repos`, and
`repo_exclusions` each take an array of key names from the `repos` hash.
They are then combined to select a set of repos from the `repos` hash
for instantiation. The formula takes one of the following two forms:
`managed_repos` - `repo_exclusions`
OR, if `manage_os_default_repos` is set to `true`
`managed_repos` + `os_default_repos` - `repo_exclusions`
Data is included for most of the CentOS default repositories, with the
exception of the "archive" repos.
This commit makes the following fixups to the README file: * Bring header tags and titles in line with the Puppet, Inc. skeleton * Standardize on non-wrapped text * Clarifies documentation for `yum::versionlock` and `yum::install`
|
I've added a whole bunch of examples to the README. Hopefully they shed some light on why this is useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds parameters to manage Yumrepo resources via data. The
primary parameter,
repos, is simply a hash of Yumrepo resources fordigestion by an each loop similar to an old
create_resources()call.It does nothing on its own, acting only as a source of data. The other
parameters control the behavior of the resource instantiation loop.
The parameters
managed_repos,os_default_repos, andrepo_exclusionseach take an array of key names from thereposhash.They are then combined to select a set of repos from the
reposhashfor instantiation. The formula takes one of the following two forms:
OR, if
manage_os_default_reposis set totrueData is included for most of the CentOS default repositories, with the
exception of the "archive" repos.