Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge unmanaged configuration files #225

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Purge unmanaged configuration files #225

merged 1 commit into from
Feb 11, 2020

Conversation

findmyname666
Copy link

Debian package for Unbound creates two additional configurations in /etc/unbound/unbound.conf.d where are some Unbound options duplicated. Please take a look on #223 for more information. This PR introduce a logic how to purge unmanaged configuration files in /etc/unbound/unbound.conf.d .

manifests/init.pp Outdated Show resolved Hide resolved
manifests/init.pp Show resolved Hide resolved
@@ -153,6 +153,7 @@
String $package_name,
Optional[String] $package_provider,
String $package_ensure,
Boolean $purge_conf_d,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a default value of false

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default value set in data/common.yaml.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think the default should be true at least on Debian, otherwise #223 would still be an issue in the default configuration

manifests/init.pp Outdated Show resolved Hide resolved
@findmyname666
Copy link
Author

@ghoneycutt please re-review. Thx.

@bastelfreak
Copy link
Member

@findmyname666 please have a look at the failing travis jobs

@findmyname666
Copy link
Author

findmyname666 commented Feb 8, 2020

@findmyname666 please have a look at the failing travis jobs

@bastelfreak i saw it but this is not my fault. Somebody use "true", "false" as String inside Enum. See error:

$ bundle exec rake $CHECK
manifests/stub.pp:33:quoted_booleans:WARNING:quoted boolean value found
manifests/stub.pp:33:quoted_booleans:WARNING:quoted boolean value found

Code in question:

Variant[Boolean, Enum['true', 'false']]            $insecure    = false,

I can remove it but i'm not sure if somebody use it.

@b4ldr
Copy link
Member

b4ldr commented Feb 10, 2020

@findmyname666 can you rebase i have added an ignore for that lint issue

Thanks

@findmyname666
Copy link
Author

@findmyname666 can you rebase i have added an ignore for that lint issue

Thanks

Done

@b4ldr
Copy link
Member

b4ldr commented Feb 11, 2020

on comment on defaults, could you also squash your commits and thanks again for the contribution

@findmyname666
Copy link
Author

findmyname666 commented Feb 11, 2020

on comment on defaults, could you also squash your commits and thanks again for the contribution

Done, thx for review and fast responses ;)

P.S.: Don't forget to deploy it on https://forge.puppet.com/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants