-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purge unmanaged configuration files #225
Conversation
manifests/init.pp
Outdated
@@ -153,6 +153,7 @@ | |||
String $package_name, | |||
Optional[String] $package_provider, | |||
String $package_ensure, | |||
Boolean $purge_conf_d, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a default value of false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default value set in data/common.yaml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually think the default should be true at least on Debian, otherwise #223 would still be an issue in the default configuration
@ghoneycutt please re-review. Thx. |
@findmyname666 please have a look at the failing travis jobs |
@bastelfreak i saw it but this is not my fault. Somebody use "true", "false" as String inside Enum. See error:
Code in question:
I can remove it but i'm not sure if somebody use it. |
@findmyname666 can you rebase i have added an ignore for that lint issue Thanks |
Done |
on comment on defaults, could you also squash your commits and thanks again for the contribution |
Done, thx for review and fast responses ;) P.S.: Don't forget to deploy it on https://forge.puppet.com/. |
Debian package for Unbound creates two additional configurations in /etc/unbound/unbound.conf.d where are some Unbound options duplicated. Please take a look on #223 for more information. This PR introduce a logic how to purge unmanaged configuration files in /etc/unbound/unbound.conf.d .