Add support for Resource Accounting via systemd #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #66 |
bastelfreak
force-pushed
the
accounting
branch
from
8291a70 to
0050c1c
Compare
|
Depends on #67 |
ekohl
reviewed
Mar 3, 2018
manifests/init.pp
Outdated
| Optional[Variant[Array,String]] $ntp_server, | ||
| Optional[Variant[Array,String]] $fallback_ntp_server, | ||
| Boolean $manage_accounting, | ||
| Hash $accounting, |
There was a problem hiding this comment.
Could this be a Hash[String, String]?
ekohl
reviewed
Mar 3, 2018
| @@ -67,6 +67,28 @@ | |||
| it { is_expected.to compile.with_all_deps } | |||
| it { is_expected.to contain_systemd__service_limits('openstack-nova-compute.service').with_limits({'LimitNOFILE' => 32768}) } | |||
| end | |||
|
|
|||
| context 'when managing Accounting options' do | |||
There was a problem hiding this comment.
I also like adding it { is_expected.to compile.with_all_deps } to my tests
bastelfreak
force-pushed
the
accounting
branch
2 times, most recently
from
89be23f to
393cf36
Compare
|
#67 was merged, so you can refactor this one. |
|
@raphink rebased it. |
|
Could you also fix the typo in the title of this PR? :) |
bastelfreak
changed the title
|
I think I fixed it :D |
ekohl
approved these changes
Mar 12, 2018
|
With this enhancement, the module is working great for me. Any thoughts about cutting a new release or moving it to voxpupuli? |
op-ct
pushed a commit
to op-ct/puppet-systemd
that referenced
this pull request
Jun 17, 2022
Contain the versionlock subclass to help with ordering around package resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.