Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for RHEL 7, CentOS 7/8, Fedora 38/39, VirtuozzoLinux 7 #496

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Drop support for RHEL 7, CentOS 7/8, Fedora 38/39, VirtuozzoLinux 7 #496

merged 1 commit into from
Nov 25, 2024

Conversation

jay7x
Copy link
Member

@jay7x jay7x commented Oct 31, 2024 •
edited
Loading

  • VirtuozzoLinux 7
  • Fedora 38, 39
  • Centos 7, 8
  • RHEL 7

@TheMeier
Copy link
Contributor

Please update the PR title to list all affected OSes.

@jay7x jay7x changed the title Drop EOL OSes Drop EOL RHEL, CentOS, Fedora, VirtuozzoLinux versions Oct 31, 2024
@jay7x
Copy link
Member Author

jay7x commented Oct 31, 2024

Do we want to make a release before dropping EOL OSes?

ekohl
ekohl requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're dropping this, I'd also like to drop the data files inhttps://github.com/voxpupuli/puppet-systemd/tree/master/data

metadata.json Show resolved Hide resolved
silug
silug requested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@silug silug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why drop Fedora support instead of updating the supported versions to ["40", "41"]?

@jay7x
Copy link
Member Author

jay7x commented Nov 7, 2024

Why drop Fedora support instead of updating the supported versions to ["40", "41"]?

Hi @silug! I saw somewhere before that dropping EOL OSes and adding new OSes should be different PRs.. though.. maybe it was about different commits instead 🤔

bastelfreak
bastelfreak reviewed Nov 11, 2024
View reviewed changes
data/Fedora.yaml Outdated Show resolved Hide resolved
@jay7x
Copy link
Member Author

jay7x commented Nov 12, 2024

Converting to Draft. Will work on adding new OSes first (to keep Fedora files untouched e.g.).

@jay7x jay7x marked this pull request as draft November 12, 2024 00:01
@rwaffen rwaffen mentioned this pull request Nov 15, 2024
Open
@jay7x
Drop EOL OSes
3c21678 
* VirtuozzoLinux 7
* Fedora 38, 39
* Centos 7, 8
* RHEL 7
@jay7x jay7x marked this pull request as ready for review November 24, 2024 09:04
@jay7x
Copy link
Member Author

jay7x commented Nov 24, 2024

Should be ready to merge now

@bastelfreak
Copy link
Member

Before we merge this, I would like to do a minor release to bring out all merged changes: #501

@bastelfreak
Copy link
Member

ah derp, we already have #480 as a breaking change

@jay7x jay7x merged commit 9f2451a into voxpupuli:master Nov 25, 2024
32 checks passed
@jay7x jay7x deleted the drop_old_oses branch November 25, 2024 08:58
@jay7x jay7x changed the title Drop EOL RHEL, CentOS, Fedora, VirtuozzoLinux versions Drop support for RHEL 7, CentOS 7/8, Fedora 38/39, VirtuozzoLinux 7 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silug silug silug requested changes

@ekohl ekohl ekohl requested changes

@TheMeier TheMeier TheMeier approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

@kenyon kenyon kenyon approved these changes

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jay7x @TheMeier @bastelfreak @kenyon @ekohl @silug