feat: add a cron like wrapper for timers #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
reviewed
Mar 2, 2024
TheMeier
force-pushed
the
issues/374
branch
2 times, most recently
from
c24e1a4 to
4c5ad0d
Compare
traylenator
requested changes
Mar 3, 2024
traylenator
reviewed
Mar 3, 2024
TheMeier
force-pushed
the
issues/374
branch
8 times, most recently
from
8b92ffd to
206bd65
Compare
traylenator
reviewed
Mar 4, 2024
This helper will allow to define a timer in a cron like way, and will setup a corresponding timer and service. In basic usage it only requires a command, user, timerspec and an ensure parameter. For additional features the parameter `service_overrides`, `timer_overrides`, `service_unit_overrides` and `timer_unit_overrides` can be used to define additional aspects of the create units. The correct order of the units is also ensured. fixes voxpupuli#374 related to voxpupuli#287
traylenator
reviewed
Mar 4, 2024
traylenator
reviewed
Mar 4, 2024
Co-authored-by: Steve Traylen <steve.traylen@cern.ch>
Co-authored-by: Steve Traylen <steve.traylen@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This helper will allow to define a timer in a cron like way, and will setup a corresponding timer and service.
In basic usage it only requires a command, user, timerspec and an ensure parameter.
For additional feaures the parameter
service_overrides,timer_overrides,service_unit_overridesandtimer_unit_overridescan be used to define additional aspects of the create units.The correct order of the units is also ensured.
This Pull Request (PR) fixes the following issues
Fixes #374
Related to #287