Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add User, Group, StandardOutput and StandardError services. #321

Closed
wants to merge 1 commit into from
Closed

Add User, Group, StandardOutput and StandardError services. #321

wants to merge 1 commit into from

Conversation

bschonec
Copy link
Contributor

@bschonec bschonec commented Mar 1, 2023

Pull Request (PR) description

I've added a few units and services that I need and were missing from this project.

@jhoblitt jhoblitt added the enhancement New feature or request label Mar 1, 2023
@jhoblitt
Copy link
Member

jhoblitt commented Mar 1, 2023

/CC @hboetes @kenyon

@jhoblitt jhoblitt mentioned this pull request Mar 1, 2023
Closed
kenyon
kenyon requested changes Mar 1, 2023
View reviewed changes
Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but REFERENCE.md needs to be updated so that the tests can run. bundle exec rake reference

@bschonec bschonec force-pushed the add_user_group_and_other branch from 5fc8f64 to 931b356 Compare March 1, 2023 19:56
@bschonec
Copy link
Contributor Author

bschonec commented Mar 1, 2023

Done

@kenyon
Copy link
Member

kenyon commented Mar 1, 2023

Now a rubocop violation, not sure where this is coming from.

Error: Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end. ([https://rubystyle.guide#empty-lines-around-bodies](https://rubystyle.guide/#empty-lines-around-bodies))
Error: Process completed with exit code 1.

@hboetes
Copy link

hboetes commented Mar 1, 2023

Much appreciated, @jhoblitt !

@bastelfreak bastelfreak changed the title Added User, Group, StandardOutput and StandardError services. Add User, Group, StandardOutput and StandardError services. Mar 2, 2023
@ekohl ekohl linked an issue Mar 20, 2023 that may be closed by this pull request
Missing WorkingDirectory parameter on Systemd::Unit::Service #320
Closed
@ekohl ekohl removed a link to an issue Mar 20, 2023
Missing WorkingDirectory parameter on Systemd::Unit::Service #320
Closed
@ekohl ekohl linked an issue Mar 20, 2023 that may be closed by this pull request
Systemd::Unit::Service: missing User and Group #299
Closed
@ekohl ekohl mentioned this pull request Mar 20, 2023
Merged
@ekohl
Copy link
Member

ekohl commented Mar 20, 2023

@bschonec I could also use this functionality (already opened #321). Any chance you can revisit this and address the feedback?

@ekohl ekohl removed a link to an issue Mar 21, 2023
Systemd::Unit::Service: missing User and Group #299
Closed
@ekohl ekohl linked an issue Mar 21, 2023 that may be closed by this pull request
Missing WorkingDirectory parameter on Systemd::Unit::Service #320
Closed
@bschonec
Copy link
Contributor Author

@bschonec I could also use this functionality (already opened #321). Any chance you can revisit this and address the feedback?

I'll try. I've got very, very little experience submitting good code to the Vox Pupuli group.

@traylenator
Copy link
Contributor

Looks fine with a re-base , obviously user and group at least added already so just add the others.

traylenator pushed a commit to traylenator/puppet-systemd that referenced this pull request Jun 15, 2023
@bschonec @traylenator
Support StandardOutput, StandardError and RequiresMountsFor.
e59ff1c 
* Allow  `StandardOutput` and `StandardError` in [Service] section.
* Allow  `RequireMountsFor` in `[Unit]` section.

* https://www.freedesktop.org/software/systemd/man/systemd.exec.html#StandardOutput=
* https://www.freedesktop.org/software/systemd/man/systemd.exec.html#StandardError=
* https://www.freedesktop.org/software/systemd/man/systemd.unit.html#RequiresMountsFor=

Note documentation for RequiresMountsFor is actually incomplete [1]

* [1] https://serverfault.com/questions/1085820/systemd-requiresmountsfor-multiline-syntax

Fixes: voxpupuli#321
@traylenator traylenator mentioned this pull request Jun 15, 2023
Merged
@bschonec
Copy link
Contributor Author

Why was this closed?

@ekohl
Copy link
Member

ekohl commented Jun 15, 2023

Because #353 implemented it.

@traylenator
Copy link
Contributor

@bschonec thanks for the patch - I used it in #353 fixed for the things that were already added.

@bschonec
Copy link
Contributor Author

Naw, you did all the work...thanks for implementing it and explaining how my issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak left review comments

@kenyon kenyon kenyon requested changes

Assignees
No one assigned
Labels
enhancement New feature or request needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing WorkingDirectory parameter on Systemd::Unit::Service
7 participants
@bschonec @jhoblitt @kenyon @hboetes @ekohl @traylenator @bastelfreak