Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(doc) Adds examples of running the service created #29

Merged
merged 1 commit into from
Oct 17, 2017

Conversation

petems
Copy link
Member

@petems petems commented Jul 5, 2017

README.md Outdated
@@ -19,6 +19,9 @@ Let this module handle file creation and systemd reloading.
::systemd::unit_file { 'foo.service':
source => "puppet:///modules/${module_name}/foo.service",
}
~> service {'foo'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a : missing?

README.md Outdated
@@ -33,6 +36,11 @@ file { '/usr/lib/systemd/system/foo.service':
source => "puppet:///modules/${module_name}/foo.service",
} ~>
Exec['systemctl-daemon-reload']

service {'foo'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well?

@bastelfreak
Copy link
Member

Hi @petems, thanks for the patch. Can you take a look at the comments?

By the way, what is in your opinion better?

include ::systemd

or

include "::systemd"

@bastelfreak
Copy link
Member

@petems ping :)

@raphink
Copy link
Member

raphink commented Oct 16, 2017

@petems could you address @bastelfreak's comments please?

@bastelfreak bastelfreak mentioned this pull request Oct 17, 2017
@petems petems force-pushed the add_service_management_example branch from 3a1e3a1 to 318bcc8 Compare October 17, 2017 20:46
@petems petems force-pushed the add_service_management_example branch from 318bcc8 to 5765ab6 Compare October 17, 2017 20:56
@petems
Copy link
Member Author

petems commented Oct 17, 2017

@raphink @bastelfreak Done! 👍

@bastelfreak
Copy link
Member

thanks!

@bastelfreak bastelfreak merged commit 531e380 into voxpupuli:master Oct 17, 2017
@raphink raphink added the enhancement New feature or request label Aug 21, 2020
op-ct pushed a commit to op-ct/puppet-systemd that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add explicit ordering to README.md
3 participants