Add MemoryLimit to limits template #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
templates/limits.erb
Outdated
| @@ -17,7 +17,8 @@ | |||
| 'LimitMSGQUEUE', | |||
| 'LimitNICE', | |||
| 'LimitRTPRIO', | |||
| 'LimitRTTIME' | |||
| 'LimitRTTIME', | |||
| 'MemoryLimit' | |||
There was a problem hiding this comment.
I'd add a trailing comma here
MemoryLimit is required to restrict memory on a systemd service effectvely. Its a more powerful and working replacement to LimitRSS= which is not implemented in linux. See man page[1] for more details. [1] http://www.dsm.fordham.edu/cgi-bin/man-cgi.pl?topic=systemd.exec&sect=5
bastelfreak
approved these changes
Mar 22, 2017
openstack-gerrit
pushed a commit
to openstack-archive/puppet-tripleo
that referenced
this pull request
Apr 3, 2017
Currently, mongodb has no limits on how much memory it can consume. This enforces restriction so mongodb service limits through systemd. The puppet-systemd module has support for limits. The MemoryLimit support is added in the follwoing pull request voxpupuli/puppet-systemd#23 Closes-bug: #1656558 Change-Id: Ie9391aa39532507c5de8dd668a70d5b66e17c891
openstack-gerrit
pushed a commit
to openstack-archive/puppet-tripleo
that referenced
this pull request
Apr 17, 2017
Currently, mongodb has no limits on how much memory it can consume. This enforces restriction so mongodb service limits through systemd. The puppet-systemd module has support for limits. The MemoryLimit support is added in the follwoing pull request voxpupuli/puppet-systemd#23 Closes-bug: #1656558 Change-Id: Ie9391aa39532507c5de8dd668a70d5b66e17c891 (cherry picked from commit 3aa86a4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemoryLimit is required to restrict memory on a
systemd service effectvely. Its a more powerful
and working replacement to LimitRSS= which is
not implemented in linux. See man page[1] for
more details.
[1] http://www.dsm.fordham.edu/cgi-bin/man-cgi.pl?topic=systemd.exec&sect=5