Notify services by default on drop in files #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systemd::dropin_file is a typeBreaking changes to this file WILL impact these 23 modules (exact match):
Breaking changes to this file MAY impact these 4 modules (near match):systemd::service_limits is a typeBreaking changes to this file WILL impact these 4 modules (exact match):Breaking changes to this file MAY impact these 2 modules (near match):This module is declared in 8 of 576 indexed public
|
bastelfreak
approved these changes
Apr 27, 2021
kenyon
approved these changes
Apr 27, 2021
op-ct
pushed a commit
to op-ct/puppet-systemd
that referenced
this pull request
Jun 17, 2022
modulesync 3.1.0
Since 97dd16f this parameter is a bad idea. It doesn't do a daemon reload and it may restart at the wrong time. In fact, I'd argue it's always been a bad idea. The recommended alternative to this is to manage the service explicitly and let Puppet handle it. There is an automatic notify that takes care of it. Fixes voxpupuli#190
This builds on 81f3eb5 which allowed services to be notified automatically. This changes it to default behavior. Fixes voxpupuli#74
ekohl
force-pushed
the
notify-service-on-drop-in
branch
from
5099b43 to
52000c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on 81f3eb5 which allowed services to be notified automatically. This changes it to default behavior.
Fixes #74
It's currently a draft since it includes #193 which I think it may depend on.