Convert from mocha to rspec-mocks #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
convert-to-rspec-mocks
branch
from
afbadc4 to
d91e1c5
Compare
This is recommended by puppetlabs_spec_helper and avoids a deprecation warning. bbed0b8 already started the conversion, but didn't update the existing fact tests. Because the mock_with call was incorrect (needs to be done before require), this didn't show.
ekohl
force-pushed
the
convert-to-rspec-mocks
branch
from
d91e1c5 to
8d0dff0
Compare
simondeziel
pushed a commit
to simondeziel/puppet-systemd
that referenced
this pull request
Jun 16, 2021
This is recommended by puppetlabs_spec_helper and avoids a deprecation warning. bbed0b8 already started the conversion, but didn't update the existing fact tests. Because the mock_with call was incorrect (needs to be done before require), this didn't show.
simondeziel
pushed a commit
to simondeziel/puppet-systemd
that referenced
this pull request
Jun 16, 2021
This is recommended by puppetlabs_spec_helper and avoids a deprecation warning. bbed0b8 already started the conversion, but didn't update the existing fact tests. Because the mock_with call was incorrect (needs to be done before require), this didn't show.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is recommended by puppetlabs_spec_helper and avoids a deprecation warning.