Allow additional option for $cache parameter (#169)

* Allow additional option for $cache parameter Update the cache parameter on init class to match the allowed values for resolved. * added tests for resolved cache variants
voxpupuli · Jan 29, 2021 · 448ec1d · 448ec1d
1 parent ea214da
commit 448ec1d
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 3 deletions.
diff --git a/manifests/init.pp b/manifests/init.pp
@@ -40,7 +40,7 @@
 #   Takes a boolean argument or "opportunistic"
 #
 # @param cache
-#   Takes a boolean argument.
+#   Takes a boolean argument or "no-negative".
 #
 # @param dns_stub_listener
 #   Takes a boolean argument or one of "udp" and "tcp".
@@ -98,7 +98,7 @@
   Optional[Variant[Boolean,Enum['resolve']]]             $multicast_dns,
   Optional[Variant[Boolean,Enum['allow-downgrade']]]     $dnssec,
   Optional[Variant[Boolean,Enum['opportunistic', 'no']]] $dnsovertls,
-  Boolean                                                $cache,
+  Optional[Variant[Boolean,Enum['no-negative']]]         $cache,
   Optional[Variant[Boolean,Enum['udp','tcp']]]           $dns_stub_listener,
   Boolean                                                $use_stub_resolver,
   Boolean                                                $manage_networkd,

diff --git a/spec/classes/init_spec.rb b/spec/classes/init_spec.rb
@@ -99,10 +99,33 @@
           it { is_expected.to contain_ini_setting('llmnr') }
           it { is_expected.to contain_ini_setting('dnssec') }
           it { is_expected.to contain_ini_setting('dnsovertls') }
-          it { is_expected.to contain_ini_setting('cache') }
+          it {
+            is_expected.to contain_ini_setting('cache').with(
+              path: '/etc/systemd/resolved.conf',
+              value: 'yes',
+            )
+          }
           it { is_expected.to contain_ini_setting('dns_stub_listener') }
         end
 
+        context 'when enabling resolved with no-negative cache variant' do
+          let(:params) do
+            {
+              manage_resolved: true,
+              cache: 'no-negative',
+            }
+          end
+
+          it { is_expected.to create_service('systemd-resolved').with_ensure('running') }
+          it { is_expected.to create_service('systemd-resolved').with_enable(true) }
+          it {
+            is_expected.to contain_ini_setting('cache').with(
+              path: '/etc/systemd/resolved.conf',
+              value: 'no-negative',
+            )
+          }
+        end
+
         context 'when enabling timesyncd' do
           let(:params) do
             {