This repository has been archived by the owner on May 5, 2023. It is now read-only.
Add retries for the file transfer #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W/o this patch Staging::file cannot handle non transient (connectivity) errors. For example, curl or wget command could be used with their --retry keys, but that would work only for transient (4xx/5xx) errors and would fail when the connection was refused. The solution is to add retries for the file transfer when non transient connection errors exist Closes-bug: #MODULES-1651 Signed-off-by: Bogdan Dobrelya <bdobrelia@mirantis.com>
nanliu
added a commit
that referenced
this pull request
Jan 15, 2015
Add retries for the file transfer
ironpinguin
referenced
this pull request
in mayflower/puppetlabs-rabbitmq
Feb 11, 2015
W/o this patch, Rabbitmq::Install::Rabbitmqadmin/Staging::File[rabbitmqadmin] /Exec[/var/lib/rabbitmq/rabbitmqadmin] sometimes could fail the curl command due to transient or connectivity errors. The solution is: - For transient errors: * use timeout param for staging::file * use --retries , --retry-delay flag for curl command passed to staging::file - For connectivity errors: * improve staging module to retry its commands as well, see https://github.com/nanliu/puppet-staging/pull/52 Closes-bug: #MODULES-1650 Signed-off-by: Bogdan Dobrelya <bdobrelia@mirantis.com>
cegeka-jenkins
pushed a commit
to cegeka/puppet-staging
that referenced
this pull request
Oct 23, 2017
Add retries for the file transfer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W/o this patch Staging::file cannot handle non transient (connectivity)
errors.
For example, curl or wget command could be used with their --retry keys,
but that would work only for transient (4xx/5xx) errors and would fail
when the connection was refused.
The solution is to add retries for the file transfer when non
transient connection errors exist
Closes-bug: #MODULES-1651
Signed-off-by: Bogdan Dobrelya bdobrelia@mirantis.com