Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

Set owner, group, mode explicitly so things work even with umask 027. #144

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Set owner, group, mode explicitly so things work even with umask 027. #144

merged 1 commit into from
Oct 12, 2017

Conversation

stefanbethke
Copy link
Contributor

Our machines py policy run with a default umask of 027; when files and directories are created by Puppet without specifying a mode explicitly, this usually leads to files not being accessible.

This change addresses the one place that the owner, group, and mode were not set.

@bastelfreak
Copy link
Member

Thanks for the PR @stefanbethke. Do we declare this as a breaking change? IMO it is.

@stefanbethke
Copy link
Contributor Author

Technically, this might be a breaking change; practically, I don't think it'll be. If consumers were happy with the directory being owned by root, but the files put there owned by $staging::owner, I don't think this change will affect them.

@bastelfreak
Copy link
Member

alrighty

@bastelfreak bastelfreak merged commit ad098af into voxpupuli:master Oct 12, 2017
@bastelfreak bastelfreak added the enhancement New feature or request label Oct 12, 2017
@stefanbethke
Copy link
Contributor Author

Thanks! Are you planning to roll a new release soon?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juniorsysadmin juniorsysadmin juniorsysadmin approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanbethke @bastelfreak @juniorsysadmin