Add defaults and make server_timeout and inotify configurable #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kallies
force-pushed
the
85_update_rhsm.conf
branch
from
426cd63 to
6157bbb
Compare
vinzent
reviewed
Feb 22, 2019
speer
reviewed
Feb 25, 2019
kallies
force-pushed
the
85_update_rhsm.conf
branch
from
6157bbb to
c459f30
Compare
kallies
force-pushed
the
85_update_rhsm.conf
branch
from
c459f30 to
ca7f057
Compare
kallies
force-pushed
the
85_update_rhsm.conf
branch
from
ca7f057 to
6fcac9b
Compare
|
@kallies could you rebase? :-) |
vinzent
added
enhancement
|
Dear @kallies, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
kallies
force-pushed
the
85_update_rhsm.conf
branch
from
6fcac9b to
89c3742
Compare
speer
reviewed
Oct 25, 2019
…oxpupuli#85) Add defaults from subscription-manager 1.21.10
kallies
force-pushed
the
85_update_rhsm.conf
branch
from
89c3742 to
f0d9048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add defaults from subscription-manager 1.21.10
Make two of them configurable:
server_timeout is measured per http call, not the overall time of a subscription-manager run. The default of 180s might lead to puppet run issues (
subscription-manager repos --list-enabledis used in the rhsm fact, this command triggers 7+ http connections).This Pull Request (PR) fixes the following issues
Fixes #85