Added SCL repo support #67
Conversation
|
I'd appreciate a datatype String and |
|
Sorry, I'm unfortunately stuck in Puppet 3 world, so I wouldn't know how to add those 2 things. I guess that this would be the first location to see datatypes because it's currently compatible with 3.8. |
|
Sting would be wrong anyway, just add the |
| @@ -169,4 +170,10 @@ | |||
| } | |||
| } | |||
|
|
|||
| if $repo_scl { | |||
| ::rhsm::repo { "rhel-server-rhscl-${::operatingsystemmajrelease}-rpms": | |||
There was a problem hiding this comment.
mirrored/cloned channels provided by redhat satellite or other tools might not use this repo name.
what if redhat decides to change channel names as they did for example with oracle jre/jdk channels?
I think the boolean param thing is not a good way to provide options for these additional channels.
the rhsm module should not try to guess repo names.
There was a problem hiding this comment.
I agree, but is there a way to get the same result, using a manifest or hiera, without having to change the module?
There was a problem hiding this comment.
@ubellavance I don't know your puppet setup. if you go with the roles/profiles pattern:
class profiles::rhsm {
include ::rhsm
rhsm::repo { "rhel-server-rhscl-${::operatingsystemmajrelease}-rpms"
}
if you need to pass config by hiera data a new $repos rhsm class parameter might be good.
class rhsm(
...
Optional[Array[String]] $repos = undef,
...
) {
...
repos.each do |String repo| {
::rhsm::repo { $repo: }
}
}
as per #66 (comment) - the code depends on if puppet3 server needs to be supported or not (this code is not puppet3 server compatible)
if the rhsm::repo supports params, then the $repos param maybe should not be an array but an hash with support for the params of rhsm::repo.
| @@ -169,4 +170,10 @@ | |||
| } | |||
| } | |||
|
|
|||
| if $repo_scl { | |||
| ::rhsm::repo { "rhel-server-rhscl-${::operatingsystemmajrelease}-rpms": | |||
| require => Exec['RHSM-register'], | |||
There was a problem hiding this comment.
maybe the defined type rhsm::repo should take care about ordering of the resource itself instead of having each caller adding manual dependencies?
There was a problem hiding this comment.
It makes sense, but I would have no idea of how to do it, unfortunately.
|
Obsolted by #78 |
|
@ubellavance would you mind closing this PR/issue, too? |
|
Dear @ubellavance, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
2 similar comments
|
Dear @ubellavance, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @ubellavance, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @ubellavance, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @ubellavance, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Hi, |
For #66