Update regexp for rabbitmq_nodename fact #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbitmqctl status returns node status without trailing points
on rabbitmq: 3.6.10, e.g:
root@rabbitmq:~# rabbitmqctl status
Status of node rabbit@rabbitmq
[{pid,16527},
....
So let's align regexp as well
|
This is definitely needed. @SergK Can you check the tests? This PR could be related to https://tickets.puppetlabs.com/browse/MODULES-3376 |
|
btw, we can merge #548 as well to fix CI |
|
@hunner could you please review and comment, thank you |
hunner
added a commit
that referenced
this pull request
Jun 29, 2017
Update regexp for rabbitmq_nodename fact
stsnel
added a commit
to thehyve/puppet-rabbitmq
that referenced
this pull request
Jul 27, 2017
Backport pull request 545 of the main puppet-rabbitmq repository, which fixes the rabbitmq_nodename fact. We need to backport it because of dependency issues with newer versions of the module.
slm0n87
pushed a commit
to slm0n87/puppet-rabbitmq
that referenced
this pull request
Mar 7, 2019
…regexp Update regexp for rabbitmq_nodename fact
cegeka-jenkins
pushed a commit
to cegeka/puppet-rabbitmq
that referenced
this pull request
Mar 26, 2021
…regexp Update regexp for rabbitmq_nodename fact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rabbitmqctl status returns node status without trailing points
on rabbitmq: 3.6.10, e.g:
root@rabbitmq:~# rabbitmqctl status
Status of node rabbit@rabbitmq
[{pid,16527},
....
So let's align regexp as well