replace r10k template with native puppet code

[bastelfreak]

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

[bastelfreak]

my old config:

---
:cachedir: /opt/puppetlabs/puppet/cache/r10k
:sources:
  puppet:
    basedir: /etc/puppetlabs/code/environments
    remote: https://github.com/voxpupuli/controlrepo.git

:deploy:
  exclude_spec: true
  generate_types: true

:pool_size: 8

the diff:

--- /etc/puppetlabs/r10k/r10k.yaml	2023-07-28 15:17:00.741299271 +0000
+++ /tmp/puppet-file20230728-37849-e7olvk	2023-07-28 21:00:18.536130396 +0000
@@ -1,12 +1,10 @@
 ---
-:cachedir: /opt/puppetlabs/puppet/cache/r10k
-:sources:
+pool_size: 8
+deploy:
+  generate_types: true
+  exclude_spec: true
+cachedir: "/opt/puppetlabs/puppet/cache/r10k"
+sources:
   puppet:
-    basedir: /etc/puppetlabs/code/environments
     remote: https://github.com/voxpupuli/controlrepo.git
-
-:deploy:
-  exclude_spec: true
-  generate_types: true
-
-:pool_size: 8
+    basedir: "/etc/puppetlabs/code/environments"

the new file:

---
pool_size: 8
deploy:
  generate_types: true
  exclude_spec: true
cachedir: "/opt/puppetlabs/puppet/cache/r10k"
sources:
  puppet:
    remote: https://github.com/voxpupuli/controlrepo.git
    basedir: "/etc/puppetlabs/code/environments"

that seems totally fine. They keys don't need to be symbols. The official documention has them as strings as well: https://github.com/puppetlabs/r10k/blob/main/doc/dynamic-environments/configuration.mkd#baseurl

[bastelfreak]

I only added the backwards-incompatible flag because we removed the parameter for the template path from the class. the generated r10k config stays the same (hopefully, at least in my tests).

[zilchms]

LGTM