Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php-fpm: Make service reload/restart configurable #598

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

bastelfreak
Copy link
Member

By default, this module uses a reload for the php-fpm service. This is
nice because it ensures that there is no downtime. But this is also bad
because certain configuration options, like unix socket owner/group will
only be changed during a restart.

Fixes: #596
Replaces: #597

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Copy link
Member

@c33s c33s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

manifests/fpm.pp Outdated Show resolved Hide resolved
manifests/init.pp Outdated Show resolved Hide resolved
manifests/fpm/service.pp Outdated Show resolved Hide resolved
By default, this module uses a reload for the php-fpm service. This is
nice because it ensures that there is no downtime. But this is also bad
because certain configuration options, like unix socket owner/group will
only be changed during a restart.

Fixes: voxpupuli#596
Replaces: voxpupuli#597
@bastelfreak bastelfreak merged commit bced0bf into voxpupuli:master Sep 2, 2020
@bastelfreak bastelfreak deleted the fpm branch September 2, 2020 18:26
@root-expert root-expert added the enhancement New feature or request label Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restart service 'php-fpm' if socket owner / group changes
4 participants