Disable failovermethod in yumrepo on EL8

[sircubbi]

Pull Request (PR) description

fix yumrepo-format for DNF (EL8 and newer)

This Pull Request (PR) fixes the following issues

failovermethod is not supported by DNF, so remove that line completly on
EL8 (and newer) as long as $priority is unset too.

[sircubbi]

Well, I cannot do against timeouts in the CI-pipeline. Could you please check or rerun it? Thanks.

[smortex]

GitHub deprecated git:// usage, can you please replace the repo URLs in .fixtures.yml to use https:// scheme instead ?

[sircubbi]

GitHub deprecated git:// usage, can you please replace the repo URLs in .fixtures.yml to use https:// scheme instead ?

OK, that fixed the timeouts. However Ubuntu fails in die external apt-module now, with something that looks like a not fully populated $facts-variable for the operating-system.

[smortex]

Good, we are moving forward.

Puppet 6, the apt module and a failing access to os.distro.codename reminds me about lsb-release but I am surprised it does not fail on more Debian based operating systems.

Can you try to add this to see if it helps: voxpupuli/puppet-jenkins@860af1e (the failure log shows that lsb_release is not found and instead of it facter use /bin/sh -c cat\ /etc/lsb-release which have less information).

[sircubbi]

Good, we are moving forward.

Puppet 6, the apt module and a failing access to os.distro.codename reminds me about lsb-release but I am surprised it does not fail on more Debian based operating systems.

Can you try to add this to see if it helps: voxpupuli/puppet-jenkins@860af1e (the failure log shows that lsb_release is not found and instead of it facter use /bin/sh -c cat\ /etc/lsb-release which have less information).

Thanks, that fixed the issue.

[smortex]

Nice! LGTM!

[bastelfreak]

thanks for fixing this!