Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RHEL 8 based distros #413

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Add support for RHEL 8 based distros #413

merged 2 commits into from
Jan 22, 2020

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Jan 2, 2020

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@ghoneycutt
Copy link
Member

Thanks, great looking PR! Could you also add support to the README under https://github.com/voxpupuli/puppet-nodejs#limitations

@bastelfreak bastelfreak added the enhancement New feature or request label Jan 2, 2020
@mmoll
Copy link
Contributor Author

mmoll commented Jan 2, 2020

There are still some problems, at least the one with the nodejs package from Nodesource can also be seen on real systems (problem is IMHO in the NodeJS RPM itself), for EPEL, I'll need to have a look...

@ghoneycutt
Copy link
Member

Appears to trying to load a template for EPEL8 which does not exist.

@mmoll
Copy link
Contributor Author

mmoll commented Jan 2, 2020

voxpupuli/puppet-epel#92 is waiting for a new module release.

@mmoll
Copy link
Contributor Author

mmoll commented Jan 18, 2020

Fot the nodesource repo to work, yum module disable -y nodejs would be needed (see nodesource/distributions#997). Is there a puppet (non-exec) way to do this?

@dhoppe
Copy link
Member

dhoppe commented Jan 22, 2020

@mmoll As far as I know puppet/yum or puppetlabs/yumrepo_core do not support the handling of modules.

You could use the template resource to create the following file:

[root@1ca0b18b505b ~]# cat /etc/dnf/modules.d/nodejs.module
[nodejs]
name=nodejs
stream=
profiles=
state=disabled

@mmoll
Copy link
Contributor Author

mmoll commented Jan 22, 2020

@dhoppe Thanks for that hint, seems to work well. 🙇‍♂️

This should be ready for review/merge then.

@bastelfreak bastelfreak merged commit cc2c86f into voxpupuli:master Jan 22, 2020
@mmoll mmoll deleted the rh8 branch January 28, 2020 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants