Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up acceptance spec helper #403

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Clean up acceptance spec helper #403

merged 1 commit into from
Oct 29, 2019

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Oct 19, 2019

No description provided.

@bastelfreak
Copy link
Member 

bastelfreak@tmu ~/modulesync_config/modules/puppet-nodejs $ puppet parser validate manifests/npm.pp 
bastelfreak@tmu ~/modulesync_config/modules/puppet-nodejs $ bundle exec rake lint
manifests/npm.pp:46:syntax:ERROR:Syntax error
Try running `puppet parser validate <file>`
bastelfreak@tmu ~/modulesync_config/modules/puppet-nodejs $ puppet parser validate manifests/npm.pp 
bastelfreak@tmu ~/modulesync_config/modules/puppet-nodejs $

no idea why this fails :(

@ekohl
Copy link
Member Author

ekohl commented Oct 19, 2019

puppet-lint doesn't understand "\\" where '\\' does appear to work.

@Wiebelt Wiebelt mentioned this pull request Oct 29, 2019
Merged
@ghoneycutt
Copy link
Member

Created #407 to fix the syntax error.

@bastelfreak bastelfreak force-pushed the spec-helper-acceptance branch from ed93212 to 81ea1ef Compare October 29, 2019 21:04
@bastelfreak
Copy link
Member

rebased the branch

@bastelfreak bastelfreak force-pushed the spec-helper-acceptance branch from 81ea1ef to d3cc33b Compare October 29, 2019 21:15
@bastelfreak bastelfreak force-pushed the spec-helper-acceptance branch from d3cc33b to 563d4b4 Compare October 29, 2019 21:16
@bastelfreak bastelfreak merged commit 5481079 into voxpupuli:master Oct 29, 2019
@ekohl ekohl deleted the spec-helper-acceptance branch October 29, 2019 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekohl @bastelfreak @ghoneycutt