npmrc can take k,v #292
Merged
npmrc can take k,v #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this patch! It looks good in general. Weird, the failing test seems to be a linter error on some lines you didn't touch. New linter settings? Paging @juniorsysadmin and @bastelfreak. @Poil do you think you could add some tests for your new feature, as well as some documentation? |
Closed
|
Rebased |
|
Great, and thanks for the tests! I'm merging this as is. If you could add some documentation, please feel super welcome to make another PR :) Thank you for the contribution. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #290
Add a npmrc_config hash to allow the possibility to add some configuration to /root/.npmrc