Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npm view package version, fix ensure=>latest bug #199

Merged
merged 1 commit into from
Jan 25, 2016
Merged

Use npm view package version, fix ensure=>latest bug #199

merged 1 commit into from
Jan 25, 2016

Conversation

joelgarboden
Copy link

Tested with tar, using npm versions 2.14.15 and 3.5.3:

  • Absent->Latest
  • Latest->Absent
  • Absent->2.2.0
  • 2.2.0->2.2.1
  • 2.2.1->latest (no change)
  • latest->2.2.0
  • 2.2.0->absent

This method doesn't work with npm 1.4.29, as npm view $PACKAGE version returns a deprecation warning about the npm version.

Thanks to @nibalizer for the npm view version pointer

@igalic
Copy link
Contributor

igalic commented Jan 19, 2016

Error: The Style/TrailingComma cop no longer exists. Please use Style/TrailingCommaInLiteral and/or Style/TrailingCommaInArguments instead.

we need a modulesync here

@juniorsysadmin
Copy link
Member

Modulesync is being done in #200 , which should fix the rubocop stuff

@jyaworski
Copy link
Member

Yes; could you rebase/squash?

@joelgarboden
Copy link
Author

@jyaworski Rebase and squashed

@jyaworski
Copy link
Member

Looks good.

jyaworski added a commit that referenced this pull request Jan 25, 2016
Use npm view package version, fix ensure=>latest bug
@jyaworski jyaworski merged commit 83f6a33 into voxpupuli:master Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants