Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Debian repository handling #118

Closed
wants to merge 2 commits into from
Closed

Conversation

paroga
Copy link
Contributor

@paroga paroga commented Mar 16, 2015

No description provided.

paroga added 2 commits March 16, 2015 19:41
Use the full fingerprint for the apt key to silence the warning.
deb.nodesource.com supports other versions via a different url too.
@juniorsysadmin
Copy link
Member

Thanks for this.

For 62c9823 are you able to add some docs to the README for repo_version, mentioning a URL if you have one (other than https://deb.nodesource.com/setup) and perhaps add some RSpec tests for this as well? This may be pretty important for anyone wanting to use 0.12.x as versions at https://deb.nodesource.com/node/ seem to have stopped at 0.10.x

In fact maybe leave 62c9823 for a separate PR and rename this one, as 0.12.x repo handling seems to be a bit in transition - https://deb.nodesource.com/setup does not match https://github.com/nodesource/distributions/blob/master/deb/setup for instance. nodesource/distributions#68 may give an indication about what is going on.

On an unrelated note, I'm not seeing updated 0.12.x rpms or a change in the rpm repo URL to accommodate 0.10 to 0.12, so NodeSource might be doing some more repo changes soon.

@paroga
Copy link
Contributor Author

paroga commented Mar 17, 2015

Is "repo_version" a good way to implement this? I'm not 100% happy with it.
Can you point me to some test, which test similar stuff?
nodesource provides packages for 0.12 via the "/node_0.12" directory on the same server, but as far as I've seen only for deb.

@igalic
Copy link
Contributor

igalic commented Mar 17, 2015

this indicates for a node-(major)-version, than a repository version, so maybe that's a better name?

@juniorsysadmin
Copy link
Member

Not to pre-empt whether this module will in future handle io.js packages as well, but another idea is to call the variable repo_url_suffix and pass this all the way down to the repo class.

$repo_url_suffix => 'iojs_1.x' - for the NodeSource io.js repo: https://deb.nodesource.com/iojs_1.x
$repo_url_suffix => 'node_0.10' - for the NodeSource Node.js 0.10 repo (param default): https://deb.nodesource.com/node_0.10
$repo_url_suffix => 'node_0.12' - for the NodeSource Node.js 0.12 repo: https://deb.nodesource.com/node_0.12

@juniorsysadmin
Copy link
Member

@juniorsysadmin
Copy link
Member

@paroga Have used this PR as the basis for #125 to try and speed things along.

@paroga paroga closed this Apr 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants