Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provider should confine to feature, which should check if npm is actually installed #202

Closed
imriz opened this issue Feb 28, 2016 · 1 comment
Closed

Provider should confine to feature, which should check if npm is actually installed #202

imriz opened this issue Feb 28, 2016 · 1 comment

Comments

@imriz
Copy link
Contributor

imriz commented Feb 28, 2016

Currently, using provider => 'npm' without dependency on the nodejs class might result a failure.
imriz added a commit to myheritage/puppet-nodejs that referenced this issue Feb 28, 2016
@imriz
Fixes voxpupuli#202 - Implement a feature check for npm
595bebb
jyaworski added a commit that referenced this issue Feb 28, 2016
@jyaworski
Merge pull request #203 from myheritage/master
1338e79 
Fixes #202 - Implement a feature check for npm
@imriz
Copy link
Contributor Author

imriz commented Feb 28, 2016

I just found out this is not being re-evaluated as I thought. I am going to open another PR with a proper fix (read: workaround).
See https://tickets.puppetlabs.com/browse/PUP-5985

cegeka-jenkins pushed a commit to cegeka/puppet-nodejs that referenced this issue Oct 23, 2017
@imriz
Fixes voxpupuli#202 - Implement a feature check for npm
b95167e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@imriz