fix for log_dir not being honored (#895) #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
requested changes
Oct 8, 2016
| context 'when log_dir is non-default' do | ||
| let(:params) { { log_dir: '/foo/bar' } } | ||
|
|
||
| it { is_expected.to contain_file('/foo/bar').with(ensure: 'directory') } |
There was a problem hiding this comment.
could you add tests for the $http_access_log and $nginx_error_log variables as well? not sure if they contain the correct path.
bastelfreak
approved these changes
Oct 8, 2016
Closed
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
fix for log_dir not being honored (voxpupuli#895)
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
fix for log_dir not being honored (voxpupuli#895)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requesting review on this possible fix for #895.
Two things: