Conditionally adding the packages if they are not added previously #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would using ensure_packages work for you? If so I'd rather use that for apt-transport-https and ca-certificates. However the passenger package should not use ensure_packages because by installing it with this module the assumption is that the package would not be declared elsewhere. |
|
Absolutely correct and thank you for pointing me to it! |
|
That's great, thanks! Could you please squash the two commits to a single commit and I'll get this merged. |
Replaced the not defined statements with a more practical ensure_packages and removed the not defined from passenger becase it should be defined only once
|
All done! |
3flex
added a commit
that referenced
this pull request
Aug 12, 2016
Merge Request #851 introduced a wrong order of installation
darken99
pushed a commit
to darken99/puppet-nginx
that referenced
this pull request
Oct 13, 2016
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Conditionally adding the packages if they are not added previously
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Merge Request voxpupuli#851 introduced a wrong order of installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We faced the problem that when using the puppet-nginx module and managing ca-certificates on our own it will bring up problems only because of assigning the same resource twice.
(ensure_resources() would be nice to use but I didn't want to add additional dependencies)