make fact work on old nginx as well #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CentOS 7 (default fact works): nginx version: nginx/1.10.0 CentOS 6: nginx: nginx version: nginx/1.0.0
|
Thanks @bastelfreak! To avoid regressions in future can you please also update/add to the test at |
3flex
added
needs-feedback
Merged
|
Ah shit I missed the tests :( thanks for creating them @3flex ! |
darken99
pushed a commit
to darken99/puppet-nginx
that referenced
this pull request
Oct 13, 2016
slm0n87
pushed a commit
to slm0n87/puppet-nginx
that referenced
this pull request
Mar 7, 2019
make fact work on old nginx as well
slm0n87
pushed a commit
to slm0n87/puppet-nginx
that referenced
this pull request
Mar 7, 2019
slm0n87
pushed a commit
to slm0n87/puppet-nginx
that referenced
this pull request
Mar 7, 2019
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
make fact work on old nginx as well
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CentOS 7 (default fact works): nginx version: nginx/1.10.0
CentOS 6: nginx: nginx version: nginx/1.0.0
Fixes #799