Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ssl_verify_client parameter #798

Merged
merged 1 commit into from
Apr 12, 2016
Merged

Conversation

rchicoli
Copy link
Contributor

the ssl_verify_client variable was hardcoded to 'on', now it is possible to pass other values like "on | off | optional | optional_no_ca".

@3flex
Copy link
Contributor

3flex commented Apr 11, 2016

Thanks for the code @rchicoli!

Couple of things:

Cheers!

@3flex 3flex added the enhancement New feature or request label Apr 11, 2016
@rchicoli rchicoli force-pushed the ssl_verify_client branch 2 times, most recently from c84112a to 251a991 Compare April 12, 2016 12:09
@rchicoli rchicoli force-pushed the ssl_verify_client branch from 251a991 to e43d8dc Compare April 12, 2016 12:14
@rchicoli
Copy link
Contributor Author

Thx for pointing out the error @3flex

  • that was pretty easy to fix
  • the ssl_verify_client parameter has to belong to some contexts, because it will only be set if ssl_client_cert is given

Glad to contribute.

@3flex 3flex merged commit b4946b7 into voxpupuli:master Apr 12, 2016
slm0n87 pushed a commit to slm0n87/puppet-nginx that referenced this pull request Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants