Add expires option to the location class #746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SNOWMEAN sorry for the huge delay. Can you please rebase on master, and squash this down to a single commit for merging? Adding new tests would also be very useful and speed up the merging process once updated. Thanks! |
|
Hi -- |
|
You can close it now, I have no time for that now, and I doubt I will have it anytime soon. |
|
Ok, thanks. It's pretty simple and seems like it could be useful (even though there are workarounds), so I will take a stab at updating it if I get some time. |
|
Replacing this for you in #924 (with test / rebase). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added "expires" option to the locations class.
We are using that option in our servers configurations, and it helps us to reduce amount of traffic significantly due to different cache expiration time for static content like jpg, css, js etc... So I think it would be nice to have it in public module as well.