restart replaced with reload in service_spec.rb file #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pallavjosh this PR is only updating the tests, you would also need to update the Puppet manifests themselves. Also please be careful with your spelling, the command would be |
|
@3flex Sorry for the typo, corrected. Though in this case manifest is already changed with pull request #702 #712 , test was unchanged. So changing test file only with this PR If In case upstream was wrong still shooting error as execution of "/etc/init.d/nginx restart" command failed. That pointed out issue. Confirming that on upstream change and puppet apply, configuration is reloaded instead of restarted. Please correct me if i'm wrong. |
pallavjosh
changed the title
|
@jfryman Please review, merge and confirm on reload part. Thanks |
|
@pallavjosh Thanks so much for the contribution! 🎩🙇🏽 |
jfryman
added a commit
that referenced
this pull request
Dec 8, 2015
restart replaced with reload in service_spec.rb file
slm0n87
pushed a commit
to slm0n87/puppet-nginx
that referenced
this pull request
Mar 7, 2019
restart replaced with reload in service_spec.rb file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jfryman related with pull request 702 comment from me. review ad confirm please.
#702