Update vhost proxy_set_header defaults to match location #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nginx::resource::location` defaults this value to `$::nginx::config::proxy_set_headers`, whereas `nginx::resource::vhost` defaults it to `[]`. This means that you get a different set of defaults if you use an explicit `nginx::resource::location` resource as opposed to setting it up via an `nginx::resource::vhost` with a proxy attribute. Updating this default value to be consistent will be less surprising.
|
👍 |
jfryman
added a commit
that referenced
this pull request
Nov 2, 2015
Update vhost proxy_set_header defaults to match location
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
Update vhost proxy_set_header defaults to match location
slm0n87
pushed a commit
to slm0n87/puppet-nginx
that referenced
this pull request
Mar 7, 2019
Update vhost proxy_set_header defaults to match location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nginx::resource::locationdefaults this value to$::nginx::config::proxy_set_headers, whereasnginx::resource::vhostdefaults it to
[]. This means that you get a different set of defaultsif you use an explicit
nginx::resource::locationresource as opposed tosetting it up via an
nginx::resource::vhostwith a proxy attribute.Updating this default value to be consistent will be less surprising.