-
-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added configuration of custom fastcgi_params [fixes #389] #396
Conversation
Hi @chaosmail, couple of comments:
|
Hi @3flex, I followed all your comments in the latest commit, the configuration now looks like this nginx::resource::location { "root":
...
ensure => present,
fastcgi => "127.0.0.1:9000",
fastcgi_param => {
'APP_ENV' => 'local',
},
} |
Awesome, that looks great to me. It's a pity that the parameter can't be called "fastcgi_params" but that might be a future enhancement. The functionality itself will certainly be useful. |
Just one last thing - if you add "fixes #389" to the issue description or one of the commits it will automatically close that issue when this is merged. |
I added it in the description, hope that's ok |
👍 |
Added configuration of custom fastcgi_params [fixes #389]
Added configuration of custom fastcgi_params [fixes voxpupuli#389]
I created a PR for Fastcgi Params #389 and proposed the key "params" for adding custom fastcgi_params in the puppet configuration.