Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ubuntu1804 as supported OS #1319

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Conversation

Dan33l
Copy link
Member

@Dan33l Dan33l commented Mar 5, 2019

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Fixes #1307

@Dan33l Dan33l changed the title add ubuntu1804 as supported OS WIP : add ubuntu1804 as supported OS Mar 5, 2019
@Dan33l Dan33l mentioned this pull request Mar 5, 2019
@dhoppe
Copy link
Member

dhoppe commented Mar 6, 2019

@Dan33l I think you need to add bionic to the array. Otherwise this module will stick to its defaults and does not manage the repository.

@Dan33l
Copy link
Member Author

Dan33l commented Mar 6, 2019

@dhoppe thank you for the comment.
I pushed the the updated array.

@LongLiveCHIEF
Copy link

I'm not sure about the package source failures. My usage of the module on 18.04 disables the package management since I provide my own source repos and management for that.

@dhoppe
Copy link
Member

dhoppe commented Mar 6, 2019

@LongLiveCHIEF At least the latest commit fixed the unit tests. The current error message is related to the acceptance tests and Passenger.

@Dan33l
Copy link
Member Author

Dan33l commented Mar 6, 2019

https://github.com/voxpupuli/puppet-nginx/blob/master/spec/acceptance/class_spec.rb#L55

The test checks the output of command dpkg -s nginx | grep ^Maintainer And with the current setup on ubuntu18.04 it gets Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>

Is it normal or not ?

With following code i suppose it is not. But perhaps it is, if i compare with Debian 9.

          class { 'nginx':
            package_source => 'passenger'
          }

@Dan33l Dan33l changed the title WIP : add ubuntu1804 as supported OS add ubuntu1804 as supported OS Mar 6, 2019
@Dan33l Dan33l merged commit e665785 into voxpupuli:master Mar 7, 2019
@Dan33l Dan33l deleted the add_ubuntu1804 branch March 7, 2019 17:04
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Ubuntu 18.04?
3 participants