Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various updates #1250

Closed
wants to merge 6 commits into from
Closed

Various updates #1250

wants to merge 6 commits into from

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Sep 30, 2018

See individual commits:

  • Remove double spacing
  • Move error_log to the http context
  • Strip line endings in mime.types
  • Use more Puppet 4 types
  • Propery handle ${client_body,proxy}_temp_path

The template already allowed setting it to false. This completes it.
@ekohl ekohl force-pushed the updates branch 2 times, most recently from eba889b to c33d62e Compare September 30, 2018 22:36
ekohl added 5 commits October 1, 2018 01:57
This ensures there are no empty lines in the file.
This aligns error_log and access_log
This double spacing doesn't align to anything so it doesn't make sense.
@alexjfisher
Copy link
Member

‘Various Updates’ is going to be too vague for the changelog. Could you update the PR title or split this into separate PRs?

@ekohl
Copy link
Member Author

ekohl commented Oct 1, 2018

As you can see the commits are cleanly split with the intention of separating. I just wanted to push my changes so they weren't just on my desktop :)

@ekohl ekohl closed this Oct 1, 2018
@ekohl ekohl deleted the updates branch October 1, 2018 11:27
@alexjfisher
Copy link
Member

@ekohl I figured that was probably the case and you just wanted to show off what you'd been up to. :)

@ekohl
Copy link
Member Author

ekohl commented Oct 1, 2018

Something like that, something like a backup :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants