Allow setting unquoted or custom flags on add_headers

[itbm]

Allows any combination of add_headers quoting.
This solves issues highlighted in #991 #992 #1020

Double Quotes:

add_header => {
    'Access-Control-Allow-Origin'      => '*' , 
}

would produce
add_header "Access-Control-Allow-Origin" "*";

Double Quotes and Unquoted

add_header => {
    'Access-Control-Allow-Origin'      => {'*' => 'always'}, 
}

would produce
add_header "Access-Control-Allow-Origin" "*" always;

Custom Quotes

add_header => {
    'Access-Control-Allow-Origin'      => {'' => '\'*\' always'}, 
}

would produce
add_header "Access-Control-Allow-Origin" '*' always;

[LongLiveCHIEF]

@itbm can you please update test specs to show these conditions? Otherwise, LGTM. Thanks!

[alexjfisher]

nginx::location also has an add_header parameter. Does its template also need updating? https://github.com/voxpupuli/puppet-nginx/blob/master/templates/server/locations/headers.erb

[itbm]

I have added it to locations and updated the tests.

[ekohl]

I do wonder if we should also rewrite this to @add_header.sort.each do |header, value|. I think that's the same but leads to cleaner code

[ekohl]

Could we include the templates/server/locations/headers.erb template here to avoid duplication?

[ekohl]

And here

[ekohl]

With https://github.com/voxpupuli/puppet-nginx/pull/1255/files#diff-47715bb968540f5a31b0a368f867a413R159 we can lose this line without any loss of functionality.

[itbm]

I have changed the sort.each and included the locations/headers.erb file in the others.

[itbm]

.

[avillarreal83]

I wanted to share that when attempting use the add_header in a hiera role, using the following puppet Hash would add the header to Nginx but the header would not be seen by Nginx due to not specifying the always setting in quotes:

Initial Puppet settings

add_header:
Strict-Transport-Security: 'max-age=31536000; includeSubDomains; always'

Initial Nginx Results

add_header "Strict-Transport-Security" "max-age=31536000; includeSubDomains;" always";

When Nginx is restarted, the header is not recognized. In order to get Nginx configuration to recognize the "always" setting I had to add some extra double quotes to the puppet Hash I had in place:

Updated Puppet settings
add_header:
Strict-Transport-Security: 'max-age=31536000; includeSubDomains;" "always'

Updated Nginx Results

add_header "Strict-Transport-Security" "max-age=31536000; includeSubDomains;" "always";

Wanted to share in case anyone else has runs into trying to use the add_header option from the server resource and experiences this issue. Using the add_header setting from this module was tricky, would be nice to make it easier to use the always setting in future releases.This is similar to what @benh57 experienced in #1020

[ajcollett]

Hi.
For all those Heira Users who see the above, here is a better way to do it, for the case above where you need to add a param after the string, and for long strings.

    add_header:
      Strict-Transport-Security: 
        'max-age=<your time>; includeSubDomains': always
      X-Frame-Options: deny
      X-Content-Type-Options: nosniff
      Content-Security-Policy: >-
        default-src 'self'; style-src 'self'; 
        style-src-elem;