Allow index_files => undef in resource::server class #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyardley
reviewed
Jul 11, 2017
There was a problem hiding this comment.
This PR looks good to me! Definitely a fan of making some of these resources optional so that configs can be made a little cleaner.
I'm not sure how easy it would be to test the absence of index_files when it's set to undef, my only thought is that if possible, maybe there should be a spec test for this?
|
@wyardley -- let me see what I can knock together for tests. |
walkamongus
force-pushed
the
optional_index_files
branch
from
31b3e48 to
58a2318
Compare
|
@wyardley I added some tests that should cover these changes. |
walkamongus
force-pushed
the
optional_index_files
branch
from
58a2318 to
971249d
Compare
|
rubocop found my single trailing comma -- fixed now |
wyardley
approved these changes
Jul 11, 2017
|
See comments in #1128 |
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
Allow index_files => undef in resource::server class
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Allow index_files => undef in resource::server class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.