Clean up nginx::resource::server #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oranenj
approved these changes
Apr 30, 2017
yastupin
reviewed
May 5, 2017
|
|
||
| # Create a proper file close stub. | ||
| if (($listen_port + 0) != ($ssl_port + 0)) { |
There was a problem hiding this comment.
Hasn't this one accidentally been dropped and not replaced?
yastupin
suggested changes
May 5, 2017
|
@yastupin: No. If I'm not reading the diff wrong, it duplicates the condition around the previous resource, so the cleanup was just to move the end of the if later. |
yastupin
approved these changes
May 5, 2017
|
@oranenj Yes thanks, I was the one reading it wrong. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
Clean up nginx::resource::server
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Clean up nginx::resource::server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.