location_cfg_prepend hash keys ignored

[igama]

I'm setting up a vhost, that should only be accessible from some IP's. Im passing the location_cfg_prepend a hash with the allow and deny keys/values.

nginx::resource::vhost { "sub.example.org":
  ensure   => present,
  proxy  => "http://sub_example_org",
  location_cfg_prepend => { 'allow' => 'IP1', 'allow' => 'IP2', 'allow' => 'IP3', 'deny' => 'all'}
}

However what I see in the config generated is :

server {
listen                *:80 ;

server_name           sub.example.org;
access_log            /var/log/nginx/sub.example.org.access.log;

location / {
 allow IP3;
 deny all;
 proxy_pass http://sub_example_org;
 proxy_read_timeout 90;
}}

Any idea what is happening to the other IPs ? why only IP3 is in the config file?

[jfryman]

The value for the key 'allow' is three different values (IP{1,2,3}).

It looks like for this to work, it should be an array of keys in order to allow multiple 'allow' blocks to be used.

[jfryman]

This will need some code modification.

[igama]

hmm ok, so i'll create 2 variables, $location_allow and $location_deny, since these are the only options that can appear multiple times on the nginx location config. Sounds good?

[jfryman]

That would probably work - if you create the variable to take an array, and then iterate through them in the template. That would be 👍

[igama]

👍 I'll try and great a pull request with the code today ;)

[apenney]

#131 should add this.

[jfryman]

Looks good. Thanks!

[igama]

👍 thanks! forgot to do the PR after...