Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[warn] the "ssl" directive is deprecated, use the "listen ... ssl" directive instead #1224

Closed
bastelfreak opened this issue Jul 7, 2018 · 3 comments · Fixed by #1225
Closed

[warn] the "ssl" directive is deprecated, use the "listen ... ssl" directive instead #1224

bastelfreak opened this issue Jul 7, 2018 · 3 comments · Fixed by #1225
Labels
bug Something isn't working

Comments

@bastelfreak
Copy link
Member

The ssl on syntax is deprecated since nginx 1.15. We should only add it if we use nginx 1.14 or older.
@bastelfreak bastelfreak added the bug Something isn't working label Jul 7, 2018
bastelfreak added a commit to bastelfreak/puppet-nginx that referenced this issue Jul 7, 2018
@bastelfreak
dont deploy "ssl on" on nginx 1.15 an newer
2c23aec 
fixes voxpupuli#1224. the option 'ssl on' within a server block is deprecated since nginx 1.15.0.
@bastelfreak bastelfreak mentioned this issue Jul 7, 2018
Merged
bastelfreak added a commit to bastelfreak/puppet-nginx that referenced this issue Jul 7, 2018
@bastelfreak
dont deploy "ssl on" on nginx 1.15 or newer
b40a76c 
fixes voxpupuli#1224. the option 'ssl on' within a server block is deprecated since nginx 1.15.0.
bastelfreak added a commit to bastelfreak/puppet-nginx that referenced this issue Jul 7, 2018
@bastelfreak
dont deploy "ssl on" on nginx 1.15 or newer
8bbbe7d 
fixes voxpupuli#1224. the option 'ssl on' within a server block is deprecated since nginx 1.15.0.
bastelfreak added a commit to bastelfreak/puppet-nginx that referenced this issue Jul 7, 2018
@bastelfreak
dont deploy "ssl on" on nginx 1.15 or newer
75af0d5 
fixes voxpupuli#1224. the option 'ssl on' within a server block is deprecated since nginx 1.15.0.
bastelfreak added a commit to bastelfreak/puppet-nginx that referenced this issue Jul 7, 2018
@bastelfreak
dont deploy "ssl on" on nginx 1.15 or newer
c1602e2 
fixes voxpupuli#1224. the option 'ssl on' within a server block is deprecated since nginx 1.15.0.
@PierreR
Copy link
Contributor

PierreR commented Oct 17, 2018

@bastelfreak Could you explain why we use a fact to retrieve the nginx_version instead of a params defined by the user ? Thanks.

@bastelfreak
Copy link
Member Author

Because the fact actually represents the installed version, and not a version a user might want to have. Are you running into any issues with this?

@PierreR
Copy link
Contributor

PierreR commented Oct 17, 2018

@bastelfreak No issue in particular. Just curious and a bit surprised as I am actually using the module to install nginx. In that case it seems a bit weird to have to go to the machine to check on the installed version.

Thanks for your quick reply !

This was referenced Dec 8, 2018
Merged
Closed
ceonizm pushed a commit to ceonizm/puppet-nginx that referenced this issue Jan 23, 2019
@bastelfreak @ceonizm
dont deploy "ssl on" on nginx 1.15 or newer
50a4c42 
fixes voxpupuli#1224. the option 'ssl on' within a server block is deprecated since nginx 1.15.0.
ceonizm pushed a commit to ceonizm/puppet-nginx that referenced this issue Jan 23, 2019
@bastelfreak @ceonizm
dont deploy "ssl on" on nginx 1.15 or newer
0eb5f1a 
fixes voxpupuli#1224. the option 'ssl on' within a server block is deprecated since nginx 1.15.0.
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this issue Sep 13, 2019
@bastelfreak
dont deploy "ssl on" on nginx 1.15 or newer
52b8f80 
fixes voxpupuli#1224. the option 'ssl on' within a server block is deprecated since nginx 1.15.0.
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this issue Oct 19, 2020
@bastelfreak
dont deploy "ssl on" on nginx 1.15 or newer
9da94eb 
fixes voxpupuli#1224. the option 'ssl on' within a server block is deprecated since nginx 1.15.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dont deploy "ssl on" on nginx 1.15 or newer bastelfreak/puppet-nginx
2 participants
@PierreR @bastelfreak