Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump puppetlabs/apt dependency #1086

Closed
den-is opened this issue May 10, 2017 · 5 comments
Closed

Bump puppetlabs/apt dependency #1086

den-is opened this issue May 10, 2017 · 5 comments
Assignees

Comments

@den-is
Copy link

den-is commented May 10, 2017

Warning: Module 'puppetlabs-apt' (v4.0.0) fails to meet some dependencies:
  'puppet-nginx' (v0.6.0) requires 'puppetlabs-apt' (>= 2.1.0 <3.0.0)

According to the Puppet Style Guide https://docs.puppet.com/puppet/latest/style_guide.html#dependencies , epel and apt are soft dependencies and should be treated as such.

@cfoehrdes
Copy link

We are also experiencing a lot of conflicts due to puppet-nginx referencing hard to this old apt module

@wyardley
Copy link
Collaborator

wyardley commented Aug 4, 2017

How about #1106 as a fix for this?

@wyardley wyardley self-assigned this Aug 4, 2017
alexjfisher added a commit that referenced this issue Aug 7, 2017
make apt a soft dependency per styleguide (resolves #1086)
booo referenced this issue in voxpupuli/puppet-collectd Aug 8, 2017
@cristianbalan-mf
Copy link

cristianbalan-mf commented Sep 1, 2017

Sorry, what's the conclusion to this? I face the same problem.

Warning: Module 'puppetlabs-apt' (v3.0.0) fails to meet some dependencies:
'puppet-nginx' (v0.6.0) requires 'puppetlabs-apt' (>= 2.1.0 <3.0.0)

Upgrading the module to 0.7.0 would still be requiring the old module but would not throw the warning?

@wyardley
Copy link
Collaborator

wyardley commented Sep 1, 2017

@cristianbalan take a look at the changes in:
https://github.com/voxpupuli/puppet-nginx/pull/1106/files
now that it's a soft dependency, the module is not explicitly required; you're just responsible for making sure that an appropriate version of the apt module is available.

@cristianbalan-mf
Copy link

Looks perfect @wyardley! Any plan to push that to Forge at some point in the next days?
Thanks.

cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this issue Sep 13, 2019
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this issue Oct 19, 2020
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this issue Oct 19, 2020
make apt a soft dependency per styleguide (resolves voxpupuli#1086)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants