'Cannot create a location reference without' rather annoying and blocks some possibilities

[dol]

The following example is not possible due to the current check of the locations paramters in

puppet-nginx/manifests/resource/location.pp

Line 233 in 0e56fa0

fail("Cannot create a location reference without a www_root, proxy, location_alias, stub_status, fastcgi, uwsgi, location_custom_cfg, internal, try_files, location_allow, or location_deny defined in ${server}:${title}")

nginx::nginx_servers:
    myserver:
        server_name:
            - 'foobar.example.com'
        listen_port: 80
        www_root: /var/www/web
        use_default_location: false
        locations:
            foobar_deny_root:
                www_root: ~
                index_files: []
                location: /
                location_custom_cfg:
                    return: 301 $scheme://$server_name/testfile
            testfile:
                www_root: ~
                index_files: []
                location: '= /testfile'

This would generate a config file like this.

# MANAGED BY PUPPET
server {
  listen *:80;
  server_name           foobar.example.com;

  root /var/www/web;
  access_log            /var/log/nginx/myserver.access.log main;
  error_log             /var/log/nginx/myserver.error.log;

  location / {
    return 301 $scheme://$server_name/testfile;
  }

  location = /testfile {
  }
}

But this is not possible, because the following error occurs:

Cannot create a location reference without a www_root, proxy, location_alias, stub_status, fastcgi, uwsgi, location_custom_cfg, internal, try_files, location_allow, or location_deny

I understand that this check was needed in combination with use_default_location to prevent the misconfiguration of the default location.

My suggestion to this problem:
Remove the restriction in the location.pp file and move the check to the server.pp file.
Apply the check where the context switch is made.

[dol]

This check was introduced 6 years ago and was since then altered from this commit: ebd481d

I don't see any usefulness having this check in the location part. Does @jfryman or someone else know the origin of this check.
Looking into the history I see the following pattern:
The check was 6 years ago introduced. Since then a random number of additional parameters where added to the list by various people. Most of them where like 'Add parameter xyz to check' like d838228

We can go on with this pattern by adding more arguments until we end up having all the resource parameters in the list.

nginx allows it to define an empty location header. There is no need to add something to the location body.

[dol]

I think a remove of the check gains more then having the check moved the server use_default_location context switch.

[juniorsysadmin]

Fixed by #1075