Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ssl_port without ssl => true makes module fail silently #1015

Closed
mzhaase opened this issue Feb 2, 2017 · 2 comments
Closed

Using ssl_port without ssl => true makes module fail silently #1015

mzhaase opened this issue Feb 2, 2017 · 2 comments

Comments

@mzhaase
Copy link

mzhaase commented Feb 2, 2017

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 4.8.1
  • Ruby: ruby 1.9.3p484 (2013-11-22 revision 43786) [x86_64-linux]
  • Distribution: Ubuntu 16.04
  • Module version: 0.6.0

How to reproduce (e.g Puppet code you use)

class { 'nginx': }
nginx::resource::server {'<name>':
      www_root    => '/var/www/test',
      listen_port => 443,
      ssl_port    => 443,
}

What are you seeing

This creates .conf in /etc/nginx/sites-enabled which only contains:

location / {
    root      /var/www/test;
    index     index.html index.htm index.php;
  }

What behaviour did you expect instead

Any kind of error message.

@wyardley
Copy link
Collaborator

I'm not sure if this is the right fix, but I'm proposing one in #1022

wyardley added a commit that referenced this issue Apr 13, 2017
warn if $ssl=false but $ssl_port == $listen_port (#1015)
@wyardley
Copy link
Collaborator

#1022 has been merged; hopefully this is sufficient.

cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this issue Sep 13, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this issue Sep 13, 2019
warn if $ssl=false but $ssl_port == $listen_port (voxpupuli#1015)
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this issue Oct 19, 2020
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this issue Oct 19, 2020
warn if $ssl=false but $ssl_port == $listen_port (voxpupuli#1015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants