-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only create database and user when mongodb_is_master #558
Conversation
Looks like this breaks tests and actually breaks idempotency in the acceptance tests. This is probably because the fact is |
@ekohl good point, I changed the condition so the code will always be executed unless the value is What do you think? |
@JvGinkel can you take a look at the failing acceptance tests? |
hrm. those issues might come for a new rspec/rspec-puppet release. CC: @alexjfisher |
Hi @bastelfreak I just did a |
@JvGinkel You can't reproduce it this morning because rspec-puppet 2.7.7 was released a few hours ago and it fixed the issue. I've restarted your build and now it passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be good to go.
This always returns true on my systems, am I missing something? Running puppet 5.5.20 with PE 2018.1 and module 3.1.0 |
@oniGino does your system have more than one node? |
Yes 3 nodes, |
Pull Request (PR) description
Only create database and user when running on a primary/master node. This way we have idempotent runs again on none primary servers.
Unfortunately the fact returns a string
true
so there is some ugliness withlint:ignore
in the if statement.This Pull Request (PR) fixes the following issues
Fixes #412