Refactor opsmanager handling #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
commented
Nov 30, 2018
bastelfreak
reviewed
Nov 30, 2018
bastelfreak
approved these changes
Nov 30, 2018
|
I don’t inheritly see a problem with using the install/config/service pattern. I’d have probably gone for simplifying the subclasses (removing unnecessary variable reassignment/bringing into scope) and removal of params.pp (as it contains no OS specific conditional logic) |
|
@ekohl Could you please take care of the RuboCop issues? |
|
Dear @ekohl, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
This removes the trivial private classes in favor of doing it all in the main class. This also means moving all params into the main class which has the side effect that the REFERENCE.md will be much more useful when generated.
ekohl
force-pushed
the
refactor-ops-handling
branch
from
79a2334
to
1de26ab
Compare
|
Updated.
Given how trivial this is now, this is much easier to follow so in this case I think it's worth it. |
bastelfreak
approved these changes
Nov 25, 2019
traylenator
approved these changes
Nov 25, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the trivial private classes in favor of doing it all in the main class. This also means moving all params into the main class which has the side effect that the REFERENCE.md will be much more useful when generated.