-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor opsmanager handling #521
Conversation
I don’t inheritly see a problem with using the install/config/service pattern. I’d have probably gone for simplifying the subclasses (removing unnecessary variable reassignment/bringing into scope) and removal of params.pp (as it contains no OS specific conditional logic) |
@ekohl Could you please take care of the RuboCop issues? |
Dear @ekohl, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
This removes the trivial private classes in favor of doing it all in the main class. This also means moving all params into the main class which has the side effect that the REFERENCE.md will be much more useful when generated.
79a2334
to
1de26ab
Compare
Updated.
Given how trivial this is now, this is much easier to follow so in this case I think it's worth it. |
This removes the trivial private classes in favor of doing it all in the main class. This also means moving all params into the main class which has the side effect that the REFERENCE.md will be much more useful when generated.