Move to Debian 9 and Ubuntu 16.04/18.04 #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ekohl
changed the title
alexjfisher
reviewed
Oct 13, 2018
| 'Debian': { | ||
| case $::operatingsystemmajrelease { | ||
| '8': { | ||
| $service_provider = pick($service_provider, 'systemd') |
There was a problem hiding this comment.
Is there nothing in the code that references $mongodb::params::service_provider anymore?
There was a problem hiding this comment.
There is, but in globals it defaults to undef anyway.
ekohl
force-pushed
the
remove-service-detection
branch
from
9ed8bb8
to
ba5d304
Compare
We should be able to rely on Puppet setting the correct defaults.
ekohl
force-pushed
the
remove-service-detection
branch
from
ba5d304
to
88f239f
Compare
ekohl
changed the title
bastelfreak
approved these changes
Oct 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be able to rely on Puppet setting the correct defaults.
Fixes GH-488