Add advanced replica set configuration #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeathBorn
force-pushed
the
advanced_replset_configuration
branch
4 times, most recently
from
7c68601
to
a3ed9e0
Compare
DeathBorn
force-pushed
the
advanced_replset_configuration
branch
from
5eb8eef
to
4f862f2
Compare
|
arbiter configuration is made through member, not through arbiter parameter. |
|
@DeathBorn great! This pull request can handle all the point of #102 ... |
|
it is running on production :) |
bastelfreak
reviewed
Aug 19, 2018
| @@ -427,7 +427,7 @@ Mutually exclusive with `replset_members` param. | |||
| ```puppet | |||
| class mongodb::server { | |||
| replset => 'rsmain', | |||
| replset_config => { 'rsmain' => { ensure => present, members => ['host1:27017', 'host2:27017', 'host3:27017'] } } | |||
| replset_config => { 'rsmain' => { ensure => present, settings => { heartbeatTimeoutSecs => 15, getLastErrorModes => { ttmode => { dc => 1 } } }, members => [{'host'=>'host1:27017', 'tags':{ 'dc' : 'east'}}, { 'host' => 'host2:27017'}, 'host3:27017'] } } | |||
There was a problem hiding this comment.
The change here to the members array is a breaking change, right? If I see this correctly, the old syntax isn't working anymore.
There was a problem hiding this comment.
Actually, it is backwards compatible.
['host1:27017', 'host2:27017', 'host3:27017']
would work as well as
[{'host'=>'host1:27017'},'host2:27017', 'host3:27017']
or
[{'host'=>'host1:27017', 'tags':{ 'dc' : 'east'}}, { 'host' => 'host2:27017'}, { 'host' => 'host3:27017'}]
because internally, this is converted to an array of hashes
bastelfreak
added
enhancement
|
Thanks! |
bastelfreak
removed
backwards-incompatible
needs-feedback
bastelfreak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add advanced replica set configuration
rs.config()["settings"]hash can be providedrs.config()["members"]replset members can be either an array of host strings like before or hashes to have custom configurationExamples
{ "replset_config": { "rs_given_name": { "ensure": "present", "settings":{ "heartbeatTimeoutSecs": 15, "getLastErrorModes": { "SomeUserCase" : { "dc": 1, "use": 1 } } }, "members": [ { "host": "host1:27017", "tags": { "dc" : "east", "use" : "readLoad"}, "hidden": false }, { "host": "host2:27017", "tags": { "dc" : "west" } }, { "host": "host2:27017", "tags": { "dc" : "east"} } ] } } }or
{ "replset_config": { "rs_given_name": { "ensure": "present", "settings":{}, "members": [ "host1:27017", "host2:27017", "host2:27017" ] } } }