-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebased PR#308 to allow other databases in the format 'role@db' for mongodb_user #432
Conversation
@bastelfreak The Travis jobs seem broken caused by ruby errors during bundle. Can you please have a look at them? |
@pecharmin I merged #434, can you please rebase? |
@pecharmin can you take a look at the failing spec tests? |
I'll review the spec tests and provide an update. |
hey, any news on this? |
c455d28
to
8c10cd8
Compare
@achevalet we cannot merge this because the tests fail. If you want you can check the code and provides fixes for it. |
ok, I will try to find spare time to fix it. |
Recently I spent time on getting some of the acceptance tests working again. It'd be great if you could write an acceptance tests for this. That'd give me a lot more confidence to merge it. |
Could you rebase this on master? looks like you included some changes from master as well. |
24bd3d2
to
335e859
Compare
@bastelfreak @ekohl rebased/squashed to master; CI tests succeeded; please review |
@pecharmin Any chance of acceptance tests as well as the unit tests? |
I'll second the request for acceptance tests. |
Hi, can this get merged? |
@craig it would be aweseome to get acceptance tests for this. Are you able to provide them? |
80d9cdd
to
6bdc562
Compare
Adopt PR voxpupuli#308 by @sharon-tickell to support assigning user roles to other database using syntax role@database. With support of @thde in voxpupuli#547 mongodb_spec: Supply explicit JSON document incl. db name to mongodb command when changing roles; see syntax https://docs.mongodb.com/manual/reference/method/db.grantRolesToUser/ Compatibility level is mongodb >= 2.6
9da481b
to
49af08c
Compare
@ekohl Could you please have a review on this PR to get it upstream? Thanks :) |
Any news on this? Would highly appreciate it :) |
Rebased an squashed @sharon-tickell changes to allow the mongodb_user provider to accept roles for other databases in the format 'role@db' from pull request #308.
I was able to grant roles using the old () and the new format (@).