Fix for MODULES-5560 #392
Fix for MODULES-5560 #392
Conversation
Two parametrs should be defined as undef, not false. mongodb_user should only use the previously constructed $hash parameter, and not the class parameters.
| @@ -35,8 +35,7 @@ | |||
|
|
|||
| mongodb_user { "User ${user} on db ${db_name}": | |||
| ensure => present, | |||
| password_hash => $password_hash, | |||
| password => $password, | |||
| password_hash => $hash, | |||
There was a problem hiding this comment.
I think this part, at least, was fixed in #393
| @@ -5,7 +5,6 @@ | |||
|
|
|||
| if($::mongodb::repo::ensure == 'present' or $::mongodb::repo::ensure == true) { | |||
| yumrepo { 'mongodb': | |||
| descr => $::mongodb::repo::description, | |||
There was a problem hiding this comment.
Puppet wouldn't deploy the code with it since the mongodb::repo::description didn't exist. Spec tests would pass but on deploy it would complain about accessing a parameter that didn't exist.
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Unknown variable: '::mongodb::repo::description'. at /etc/puppetlabs/code/environments/database/modules/mongodb/manifests/repo/yum.pp:8:25 on node mongo-db.mydomain.com
There was a problem hiding this comment.
Are you perhaps using the latest release since that include 780da69 and fixes the issue properly.
There was a problem hiding this comment.
No. I forked the codebase back a bit over a month ago to work on getting the Auth settings to work right (see my other pull requests). This was one of several independent fixes I had to make to get to the end goal. I tried to keep them as separate pull requests so that the auth branch work didn't get distracted with several different bug fixes.
I've drifted a fair amount and several branches away. I could try a resync with the master. If this is fixed elsewhere, happy to let it drop. Real concern is getting the auth branch pulled into master so that we can run MongoDB with auth turned on.
There was a problem hiding this comment.
I should add that there isn't a pull request for the Auth flag yet because I was looking for additional testing. I've talked about it and given a reference to my own fork in the nominated bug report (MODULES-5560). If you're interested in having a more formal look at it, I'll put in a pull request for you.
There was a problem hiding this comment.
If you could rebase this test and verify it's still needed that would be appreciated.
Two parametrs should be defined as undef, not false.
mongodb_user should only use the previously constructed $hash parameter, and not the class parameters.