-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could not find scope for mongodb::params #428
Comments
@pschichtel Thanks for reporting this. Could you share a complete example of how you're using this module? It looks like there may be some sort of circular inheritance going on. Very, very similar to this postgresql module bug report. |
The fix in postgresql module is puppetlabs/puppetlabs-postgresql@1507123 |
it is just: include ::mongodb::server
include ::mongodb::client with the following hiera keys: mongodb::globals::manage_package_repo: true
mongodb::globals::manage_package: true
mongodb::server::auth: false
mongodb::server::bind_ip: '0.0.0.0'
mongodb::server::storage_engine: 'wiredTiger' |
Setting manage_package_repo to false will solve/hide the problem. |
This happens with puppet 5.3.3 as well |
I have still the exact same problem. |
mongodb::globals includes mongodb::repo mongodb::repo inherits from mongodb::params mongodb::params inherits from globals We work around this by removing the inheritance from mongodb::repo and requiring explicit parameters. We then pass in the parameters explicitly in mongodb::globals. Since repo is a private class this shouldn't be considered breaking an API. While we're at it we add types to the parameters we change. Fixes voxpupuli#428
@pschichtel could you test #474 and see if it fixes your issue? |
@ekohl the dependency problem is gone, but APT is telling me the repo isn't signed which seems wrong. I guess the issue reported here is fixed then. |
mongodb::globals includes mongodb::repo mongodb::repo inherits from mongodb::params mongodb::params inherits from globals We work around this by removing the inheritance from mongodb::repo and requiring explicit parameters. We then pass in the parameters explicitly in mongodb::globals. Since repo is a private class this shouldn't be considered breaking an API. While we're at it we add types to the parameters we change. Fixes voxpupuli#428
Affected Puppet, Ruby, OS and module versions/distributions
How to reproduce (e.g Puppet code you use)
enable manage_package_repo in globals.pp
What are you seeing
What behaviour did you expect instead
I expected the apt source list to be created by puppet.
Output log
see above
Any additional information you'd like to impart
n/a
The text was updated successfully, but these errors were encountered: